-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClusterIP to the services in the egctl test data #1758
Add ClusterIP to the services in the egctl test data #1758
Conversation
Co-authored-by: tony-2023 <138949958+tony-2023@users.noreply.github.com> Signed-off-by: Ronnie Personal <76408835+Ronnie-personal@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1758 +/- ##
==========================================
+ Coverage 65.02% 65.13% +0.10%
==========================================
Files 84 84
Lines 12144 12151 +7
==========================================
+ Hits 7897 7914 +17
+ Misses 3740 3733 -7
+ Partials 507 504 -3
|
thanks @Ronnie-personal ! does this allow you to add the |
Yes, we will be able to add endpoints ValidateAll(), after this change. |
Can you add ValidateAll into this PR as well ? |
Sure, will do. |
Signed-off-by: Ronnie Personal <76408835+Ronnie-personal@users.noreply.github.com>
Signed-off-by: Ronnie Personal <76408835+Ronnie-personal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
What type of PR is this? fix: fix egctl test data, also add endpoints ValidateAll().
What this PR does / why we need it: xds endpoint configuration requires address under socketAddress field. We need to provide ClusterIP in the input data file.
Which issue(s) this PR fixes: #1742
Fixes #