api: add stats_matcher for envoy's stats #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmsnan
force-pushed
the
dev-add-envoy-stats-matcher-and-histogrambucketsettings
branch
from
71ed779
to
21d1e0e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
+ Coverage 65.22% 65.27% +0.04%
==========================================
Files 86 86
Lines 12318 12318
==========================================
+ Hits 8034 8040 +6
+ Misses 3772 3766 -6
Partials 512 512 |
|
please add api first |
tmsnan
force-pushed
the
dev-add-envoy-stats-matcher-and-histogrambucketsettings
branch
from
21d1e0e
to
5c148d1
Compare
tmsnan
force-pushed
the
dev-add-envoy-stats-matcher-and-histogrambucketsettings
branch
from
5c148d1
to
2f6f0b7
Compare
tmsnan
changed the title
done |
arkodg
reviewed
Aug 4, 2023
tmsnan
force-pushed
the
dev-add-envoy-stats-matcher-and-histogrambucketsettings
branch
from
3e4dfa3
to
6cf8fa7
Compare
|
/retest |
arkodg
reviewed
Aug 7, 2023
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
tmsnan
force-pushed
the
dev-add-envoy-stats-matcher-and-histogrambucketsettings
branch
from
e5da312
to
45bc763
Compare
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
tmsnan
changed the title
arkodg
reviewed
Aug 22, 2023
arkodg
reviewed
Aug 22, 2023
arkodg
reviewed
Aug 22, 2023
arkodg
reviewed
Aug 22, 2023
|
thanks for incorporating the suggestions @tmsnan, had some more minor suggestions around comments and doc string, overall LGTM |
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
arkodg
reviewed
Aug 22, 2023
api/config/v1alpha1/metric_types.go
Outdated
| @@ -10,6 +10,14 @@ type ProxyMetrics struct { | |||
| Prometheus *PrometheusProvider `json:"prometheus,omitempty"` | |||
| // Sinks defines the metric sinks where metrics are sent to. | |||
| Sinks []MetricSink `json:"sinks,omitempty"` | |||
| // Matches defines configuration for selecting specific metrics instead of generating all metrics stats | |||
| // that are enabled by default. This helps reduce CPU and memory overhead in Envoy. | |||
| // When Matches is nil(not set), gateway by default create and expose only a subset of | |||
There was a problem hiding this comment.
lines 15-19 can be removed, imo
also because its hard to define in docs what exactly the default stats are, for e.g. we currently also output http stats
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
|
/retest |
zirain
approved these changes
Aug 23, 2023
tmsnan
deleted the
dev-add-envoy-stats-matcher-and-histogrambucketsettings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api: add stats_matcher for envoy's stats
Relates to #1669