Add a Name field to a IR Route Destination

[arkodg]

• Allows us to reduce and reuse the number of xds clusters created which are per xRoute per rule
  Fixes: Per HttpRoute(API) cluster creation #551

• Removes the hostname from the xds cluster name since the xds cluster name is no longer tied to the ir route name
  Fixes: Prometheus stats not working with EG generated cluster names #1785

• Also append Kind (httproute / grpcroute) to the IR Route and IR RouteDestination names so the generated xds routes and clusters are unique across different GAPI resource types and dont collide

[codecov]

Codecov Report

Merging #1788 (e706eac) into main (c5c675f) will increase coverage by 0.05%.
The diff coverage is 80.14%.

@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   65.05%   65.11%   +0.05%     
==========================================
  Files          86       86              
  Lines       12281    12316      +35     
==========================================
+ Hits         7989     8019      +30     
- Misses       3777     3782       +5     
  Partials      515      515              

Files Changed	Coverage Δ
internal/ir/zz_generated.deepcopy.go	13.78% <38.46%> (+0.86%)	⬆️
internal/xds/translator/authentication.go	65.21% <66.66%> (-0.12%)	⬇️
internal/xds/translator/ratelimit.go	86.21% <66.66%> (-0.05%)	⬇️
internal/ir/xds.go	73.60% <70.37%> (+0.79%)	⬆️
internal/xds/translator/route.go	90.76% <83.33%> (+0.10%)	⬆️
internal/xds/translator/translator.go	78.24% <83.33%> (+1.90%)	⬆️
internal/gatewayapi/route.go	88.28% <98.48%> (+0.25%)	⬆️
internal/gatewayapi/filters.go	80.30% <100.00%> (+0.17%)	⬆️
internal/gatewayapi/helpers.go	80.38% <100.00%> (+0.15%)	⬆️
internal/xds/translator/accesslog.go	98.19% <100.00%> (-0.02%)	⬇️
... and 2 more

... and 1 file with indirect coverage changes

[arkodg]

looks like I broke the Redirect conformance tests

2023-08-16T22:10:53.4357382Z     --- FAIL: TestGatewayAPIConformance/HTTPRouteRedirectHostAndStatus (60.04s)
2023-08-16T22:10:53.4358026Z     --- FAIL: TestGatewayAPIConformance/HTTPRouteRedirectPath (60.02s)
2023-08-16T22:10:53.4358767Z     --- FAIL: TestGatewayAPIConformance/HTTPRouteRedirectPortAndScheme (60.08s)
2023-08-16T22:10:53.4361651Z     --- FAIL: TestGatewayAPIConformance/HTTPRouteRedirectPort (60.02s)
2023-08-16T22:10:53.4362251Z     --- FAIL: TestGatewayAPIConformance/HTTPRouteRedirectScheme (60.02s)

looking into this rn

[zhaohuabing]

Please correct me if I am wrong:

This PR creates one cluster per route rule, eliminating the duplicated clusters when a route is attached to multiple gateway listeners. However, if a backend service is referenced in more than one route, there still are duplicated clusters created for that service. Should we consider creating one cluster per backend service?

[arkodg]

Please correct me if I am wrong:

This PR creates one cluster per route rule, eliminating the duplicated clusters when a route is attached to multiple gateway listeners. However, if a backend service is referenced in more than one route, there still are duplicated clusters created for that service. Should we consider creating one cluster per backend service?

good point, here's the thing, the xds cluster also contains other attributes such as loadbalancing and resiliency (outlier detection) that may be applied at a per xRoute per Rule level via a PolicyAttachment, so we need to create different clusters for those cases :)

[AliceProxy]

Looks good to me and the xDS names are clean

[arkodg]

lets wait another day for #1702 to go in, before this PR goes in, 1702 has already had to rebase a few times