Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm make target helm-release #1796

Merged
merged 2 commits into from Aug 18, 2023
Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 17, 2023

  • its not used anywhere and is indentical to helm-package

* its not used anywhere and is indentical to `helm-package`

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner August 17, 2023 18:39
@arkodg arkodg requested a review from Xunzhuo August 17, 2023 18:39
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1796 (85d22ae) into main (741e6b5) will decrease coverage by 0.29%.
The diff coverage is n/a.

❗ Current head 85d22ae differs from pull request most recent head 956e1b0. Consider uploading reports for the commit 956e1b0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   65.13%   64.84%   -0.29%     
==========================================
  Files          84       84              
  Lines       12230    12209      -21     
==========================================
- Hits         7966     7917      -49     
- Misses       3755     3783      +28     
  Partials      509      509              

see 4 files with indirect coverage changes

@zirain
Copy link
Contributor

zirain commented Aug 18, 2023

cc @Xunzhuo

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clean-up, thanks.

@Xunzhuo Xunzhuo merged commit 080674a into envoyproxy:main Aug 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants