Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use / instead of - in IR Route Name #1814

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 22, 2023

@arkodg arkodg requested a review from a team as a code owner August 22, 2023 01:06
@arkodg arkodg marked this pull request as draft August 22, 2023 01:06
@arkodg
Copy link
Contributor Author

arkodg commented Aug 22, 2023

keeping in draft mode until #1798 is merged

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1814 (f0804c6) into main (c7c0b9d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
+ Coverage   65.12%   65.23%   +0.11%     
==========================================
  Files          86       86              
  Lines       12469    12473       +4     
==========================================
+ Hits         8120     8137      +17     
+ Misses       3829     3820       -9     
+ Partials      520      516       -4     
Files Changed Coverage Δ
internal/gatewayapi/route.go 88.38% <100.00%> (+0.01%) ⬆️
internal/xds/translator/authentication.go 65.21% <100.00%> (ø)
internal/xds/translator/translator.go 78.49% <100.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
to workaround envoyproxy/envoy#4357

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg marked this pull request as ready for review August 28, 2023 21:52
@arkodg arkodg requested review from a team, zhaohuabing, chauhanshubham and Xunzhuo and removed request for a team August 28, 2023 21:59
@zirain zirain merged commit 57e669f into envoyproxy:main Aug 29, 2023
18 checks passed
@arkodg arkodg deleted the use-slash-route-name branch August 29, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants