Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the missing required field type #1848

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

rootsongjc
Copy link
Member

Fix the tracing example configuration error: missing the required field "type", see the TracingProvider.

Signed-off-by: Jimmy Song <rootsongjc@gmail.com>
@rootsongjc rootsongjc requested a review from a team as a code owner August 30, 2023 02:35
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1848 (22d1291) into main (d53dc1f) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   65.24%   65.12%   -0.13%     
==========================================
  Files          86       86              
  Lines       12476    12476              
==========================================
- Hits         8140     8125      -15     
- Misses       3819     3831      +12     
- Partials      517      520       +3     

see 2 files with indirect coverage changes

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Xunzhuo Xunzhuo merged commit bde72ab into envoyproxy:main Aug 30, 2023
11 checks passed
@rootsongjc rootsongjc deleted the provider branch August 30, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants