fix: allow to set imagePullPolicy for kube-rbac-proxy container #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaHenderson
changed the title
ElenaHenderson
force-pushed
the
allow-to-set-imagePullPolicy-for-kube-rbac-proxy
branch
2 times, most recently
from
9f65e03
to
5d22f04
Compare
zirain
reviewed
Aug 31, 2023
charts/gateway-helm/values.tmpl.yaml
Outdated
| @@ -15,6 +15,7 @@ deployment: | |||
| image: | |||
| repository: gcr.io/kubebuilder/kube-rbac-proxy | |||
| tag: v0.14.1 | |||
| imagePullPolicy: Always | |||
There was a problem hiding this comment.
change this to IfNotPresent?
There was a problem hiding this comment.
Thank you! Updated.
Codecov Report
@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
- Coverage 65.28% 65.25% -0.04%
==========================================
Files 86 86
Lines 12480 12480
==========================================
- Hits 8148 8144 -4
- Misses 3816 3819 +3
- Partials 516 517 +1 |
ElenaHenderson
force-pushed
the
allow-to-set-imagePullPolicy-for-kube-rbac-proxy
branch
2 times, most recently
from
9ece828
to
f28af40
Compare
Signed-off-by: Elena <elenavhenderson@gmail.com>
Signed-off-by: Elena <elenavhenderson@gmail.com>
Signed-off-by: Elena <elenavhenderson@gmail.com>
Signed-off-by: Elena <elenavhenderson@gmail.com>
ElenaHenderson
force-pushed
the
allow-to-set-imagePullPolicy-for-kube-rbac-proxy
branch
from
f28af40
to
dd2e6d5
Compare
zirain
approved these changes
Sep 2, 2023
arkodg
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds ability to set imagePullPolicy for kube-rbac-proxy container for gateway-helm chart
What this PR does / why we need it:
I need this so I can control this setting for air-gapped env where images can not be pulled.
Which issue(s) this PR fixes:
Fixes # #1857