Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix unicode error #1877

Merged
merged 3 commits into from Sep 12, 2023
Merged

chore: fix unicode error #1877

merged 3 commits into from Sep 12, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Sep 11, 2023

@zirain
chore: fix unicode error
1f89d5e 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner September 11, 2023 13:14
@zirain
update
9d357c5 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
update
94a99f5 
Signed-off-by: zirain <zirain2009@gmail.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1877 (94a99f5) into main (2e6211a) will increase coverage by 0.08%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   65.31%   65.39%   +0.08%     
==========================================
  Files          86       86              
  Lines       12526    12528       +2     
==========================================
+ Hits         8181     8193      +12     
+ Misses       3827     3818       -9     
+ Partials      518      517       -1
Files Changed Coverage Δ
internal/xds/translator/jsonpatch.go 30.80% <30.00%> (+0.70%) ⬆️

... and 2 files with indirect coverage changes

zirain
zirain commented Sep 11, 2023
View reviewed changes
internal/xds/translator/jsonpatch.go
@@ -291,3 +292,9 @@ func processJSONPatches(tCtx *types.ResourceVersionTable, envoyPatchPolicies []*
}
return errs
}

var unescaper = strings.NewReplacer(" ", " ")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace [NBSP] to

@arkodg arkodg mentioned this pull request Sep 11, 2023
Merged
zhaohuabing
zhaohuabing approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for cleaning up.

@zirain zirain merged commit 2ffd67b into envoyproxy:main Sep 12, 2023
17 of 18 checks passed
@zirain zirain deleted the unicode branch September 12, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zirain @zhaohuabing @arkodg