Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: move gateway namespace mode to common helper #2129

Merged
merged 1 commit into from Nov 10, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 31, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner October 31, 2023 07:36
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2129 (e9a94a9) into main (179d265) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2129      +/-   ##
==========================================
+ Coverage   64.32%   64.33%   +0.01%     
==========================================
  Files         107      107              
  Lines       14623    14617       -6     
==========================================
- Hits         9406     9404       -2     
+ Misses       4654     4650       -4     
  Partials      563      563              
Files Coverage Δ
internal/provider/kubernetes/kubernetes.go 63.82% <100.00%> (-4.10%) ⬇️

... and 2 files with indirect coverage changes

@Xunzhuo Xunzhuo changed the title opt: codes opt: move gateway namespace mode to common helper Oct 31, 2023
@Xunzhuo Xunzhuo requested review from a team, kflynn, AliceProxy and cnvergence and removed request for a team October 31, 2023 10:50
Copy link
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg merged commit c85f0e4 into envoyproxy:main Nov 10, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants