Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix invalid title in cors #2173

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 10, 2023

What type of PR is this?

docs: fix invalid doc

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner November 10, 2023 08:03
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2173 (d265879) into main (ad38383) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   64.29%   64.34%   +0.05%     
==========================================
  Files         107      107              
  Lines       14671    14671              
==========================================
+ Hits         9432     9440       +8     
+ Misses       4671     4664       -7     
+ Partials      568      567       -1     

see 2 files with indirect coverage changes

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@arkodg arkodg merged commit 8b5cc95 into envoyproxy:main Nov 10, 2023
18 checks passed
@shawnh2 shawnh2 deleted the doc-fix-cors branch November 11, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants