Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update gatewayapi resources version and fix dead link #2190

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 15, 2023

What type of PR is this?

docs fix

What this PR does / why we need it:

  • bump gatwayapi resources GatewayClass, Gateway, HTTPRoute version to v1
  • convert https://gateway.envoyproxy.io/... like absolute path to relative path, fix all the 404 pages
  • fix dead or outdated links
  • fix typos

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner November 15, 2023 06:48
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f92da90) 64.17% compared to head (c94af34) 64.20%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
+ Coverage   64.17%   64.20%   +0.03%     
==========================================
  Files         107      107              
  Lines       14922    14924       +2     
==========================================
+ Hits         9576     9582       +6     
+ Misses       4770     4767       -3     
+ Partials      576      575       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunzhuo
Copy link
Member

Xunzhuo commented Nov 15, 2023

Thanks, for bumping gwapi resources versions, should we also update them in v0.6.0 since eg v0.6 is already used v1.0.0 .

@shawnh2
Copy link
Contributor Author

shawnh2 commented Nov 15, 2023

Thanks, for bumping gwapi resources versions, should we also update them in v0.6.0 since eg v0.6 is already used v1.0.0 .

no problem

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2
Copy link
Contributor Author

shawnh2 commented Nov 17, 2023

the changes has been made, PTAL @Xunzhuo

@zirain zirain merged commit 768e4a2 into envoyproxy:main Nov 17, 2023
18 checks passed
@shawnh2 shawnh2 deleted the fix-doc-deadlink branch November 17, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants