Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: tcpKeepAlive in BackendTrafficPolicy #2194

Merged
merged 1 commit into from Nov 17, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 16, 2023

Relates to #1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner November 16, 2023 01:04
@arkodg arkodg changed the title api: keepAlive in BackendTrafficPolicy api: tcpKeepAlive in BackendTrafficPolicy Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99b1642) 64.17% compared to head (05b6b05) 64.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
+ Coverage   64.17%   64.21%   +0.03%     
==========================================
  Files         107      107              
  Lines       14924    14924              
==========================================
+ Hits         9578     9583       +5     
+ Misses       4770     4766       -4     
+ Partials      576      575       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also have keep alive option for downstream connections?

@arkodg
Copy link
Contributor Author

arkodg commented Nov 16, 2023

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Xunzhuo Xunzhuo merged commit 974b515 into envoyproxy:main Nov 17, 2023
18 checks passed
@arkodg arkodg deleted the keepalive-btp branch November 17, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants