Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update egctl install cmd #2218

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Nov 20, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

update egctl install cmd

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner November 20, 2023 06:58
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7b1756) 64.37% compared to head (fe1f8a5) 64.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
- Coverage   64.37%   64.33%   -0.04%     
==========================================
  Files         109      109              
  Lines       15302    15302              
==========================================
- Hits         9851     9845       -6     
- Misses       4842     4847       +5     
- Partials      609      610       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunzhuo Xunzhuo requested review from a team, LanceEa, cnvergence, chauhanshubham and shawnh2 and removed request for a team November 20, 2023 07:22
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zirain zirain merged commit 6e064c6 into envoyproxy:main Nov 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants