fix: trim hyphen suffix in resource name #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
==========================================
+ Coverage 64.37% 64.42% +0.05%
==========================================
Files 110 111 +1
Lines 15343 15362 +19
==========================================
+ Hits 9877 9897 +20
Misses 4854 4854
+ Partials 612 611 -1 ☔ View full report in Codecov by Sentry. |
|
can you add a test for this? |
arkodg
reviewed
Nov 20, 2023
cnvergence
force-pushed
the
fix-port-name-hyphens
branch
from
fab3396
to
4e0c945
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
fix-port-name-hyphens
branch
from
4e0c945
to
77eee82
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
|
/retest |
zirain
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2201