Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken format on JWT #2240

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ardikabs
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2239

Signed-off-by: Ardika Bagus <me@ardikabs.com>
@ardikabs ardikabs requested a review from a team as a code owner November 24, 2023 08:44
@zirain
Copy link
Contributor

zirain commented Nov 24, 2023

right now github page doesn't support preview, can you kindly post a screenshort for this change?

you can run make docs-serve locally.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73fbd62) 64.53% compared to head (5606251) 64.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2240   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files         111      111           
  Lines       15542    15542           
=======================================
  Hits        10030    10030           
  Misses       4896     4896           
  Partials      616      616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ardikabs
Copy link
Contributor Author

Hi @zirain, below is the local screenshot for this change:
image

@zirain zirain merged commit dcc0ee0 into envoyproxy:main Nov 24, 2023
18 checks passed
@ardikabs ardikabs deleted the docs/jwt-broken-format branch November 24, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: broken format displayed under JWT reference
3 participants