Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user docs for basic auth #2246

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Nov 28, 2023

Related to: #1660
Close #2227

@zhaohuabing zhaohuabing requested a review from a team as a code owner November 28, 2023 07:32
@zhaohuabing zhaohuabing marked this pull request as draft November 28, 2023 07:32
@zhaohuabing zhaohuabing force-pushed the basic-auth-doc branch 2 times, most recently from 2e2910e to 818e0f1 Compare November 28, 2023 07:34
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b816e34) 64.26% compared to head (ac99c08) 64.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2246      +/-   ##
==========================================
+ Coverage   64.26%   64.28%   +0.01%     
==========================================
  Files         112      112              
  Lines       15728    15728              
==========================================
+ Hits        10108    10111       +3     
+ Misses       4979     4976       -3     
  Partials      641      641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing force-pushed the basic-auth-doc branch 2 times, most recently from 9eb7b20 to 5ae74c0 Compare November 28, 2023 12:50
@zhaohuabing zhaohuabing marked this pull request as ready for review November 28, 2023 12:51
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain
Copy link
Contributor

zirain commented Nov 28, 2023

/retest

@zirain zirain merged commit 0add22b into envoyproxy:main Nov 29, 2023
18 checks passed
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Nov 29, 2023
docs for basic auth

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Nov 29, 2023
docs for basic auth

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Nov 29, 2023
docs for basic auth

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zirain pushed a commit that referenced this pull request Nov 30, 2023
user docs for basic auth (#2246)

docs for basic auth

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Auth docs
3 participants