Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update otel collector chart version #2254

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Nov 29, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain added the hold do not merge label Nov 29, 2023
@zirain zirain requested a review from a team as a code owner November 29, 2023 13:42
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0add22b) 64.26% compared to head (b7b0fbb) 64.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2254      +/-   ##
==========================================
+ Coverage   64.26%   64.31%   +0.05%     
==========================================
  Files         112      112              
  Lines       15728    15728              
==========================================
+ Hits        10107    10115       +8     
+ Misses       4980     4973       -7     
+ Partials      641      640       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunzhuo
Copy link
Member

Xunzhuo commented Nov 30, 2023

@zirain noticed that added a hold label, what is the concern ?

@zirain zirain removed the hold do not merge label Nov 30, 2023
@zirain
Copy link
Contributor Author

zirain commented Nov 30, 2023

@Xunzhuo Xunzhuo enabled auto-merge (squash) November 30, 2023 05:49
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xunzhuo Xunzhuo merged commit d60b4f7 into envoyproxy:main Nov 30, 2023
18 checks passed
@zirain zirain deleted the test/otel-collector branch November 30, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants