fix: when service type = clusterIP set the address to service.clusterIP #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShyunnY
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2582 +/- ##
==========================================
- Coverage 64.11% 64.03% -0.08%
==========================================
Files 119 119
Lines 18561 18640 +79
==========================================
+ Hits 11901 11937 +36
- Misses 5880 5918 +38
- Partials 780 785 +5 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Feb 9, 2024
|
we'll also need to update the logic in gateway/internal/status/gateway.go Line 30 in d44f4be ClusterIP is updated in the statusthe if/else will need to be refactored a bit
|
…nvoyproxy#2166) Signed-off-by: ShyunnY <1147212064@qq.com>
Yes, I've made changes |
shawnh2
approved these changes
Feb 11, 2024
|
/retest |
zirain
approved these changes
Feb 12, 2024
vixns
pushed a commit
to vixns/gateway
that referenced
this pull request
Feb 18, 2024
…IP (envoyproxy#2582) when service type = clusterIP set the address to service.clusterIP (envoyproxy#2166) Signed-off-by: ShyunnY <1147212064@qq.com> Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: when service type = clusterIP set the address to service.clusterIP
What this PR does / why we need it:
This commit solves the problem that when setting Service Type=ClusterIP and customizing the address for Gateway.spec.addresses, the address is incorrectly set to externalIPs.
I fixed it so that it can be correctly set to the ClusterIP
Which issue(s) this PR fixes:
Fixes #2166