Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update gateway-address doc #2638

Merged
merged 4 commits into from Feb 19, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Feb 17, 2024

update gateway-address doc content according to #2166

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner February 17, 2024 13:02
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (199f50c) 63.41% compared to head (e5fe866) 63.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         119      119           
  Lines       19227    19227           
=======================================
  Hits        12193    12193           
  Misses       6222     6222           
  Partials      812      812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Feb 17, 2024

/retest

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zirain
zirain previously approved these changes Feb 17, 2024
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zhaohuabing zhaohuabing merged commit 56a0178 into envoyproxy:main Feb 19, 2024
20 checks passed
@shawnh2 shawnh2 deleted the update-gateway-addr-doc branch February 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants