fix: helm-template should explicitly set ns #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bitliu <bitliu@tencent.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
==========================================
+ Coverage 64.88% 64.90% +0.02%
==========================================
Files 121 121
Lines 21393 21393
==========================================
+ Hits 13880 13886 +6
+ Misses 6643 6639 -4
+ Partials 870 868 -2 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Apr 1, 2024
shawnh2
approved these changes
Apr 1, 2024
ShyunnY
pushed a commit
to ShyunnY/gateway
that referenced
this pull request
Apr 1, 2024
Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
After #2793