Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add idleTimeout to ClientTrafficPolicy for TCP listener #3345

Merged
merged 7 commits into from
May 15, 2024

Conversation

aoledk
Copy link
Contributor

@aoledk aoledk commented May 8, 2024

What this PR does / why we need it:

Add idleTimeout to ClientTrafficPolicy for TCP listener.

Which issue(s) this PR fixes:

Fixes #3343

Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
@aoledk aoledk requested a review from a team as a code owner May 8, 2024 07:32
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good me, just one comment on the doc

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good me, just one comment on the doc

// Timeout settings for HTTP.
//
// +optional
HTTP *HTTPClientTimeout `json:"http,omitempty"`
}

type TCPClientTimeout struct {
// IdleTimeout for a TCP connection. Idle time is defined as a period in which there are no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this will be implemented for the envoy TCP Proxy, right? Maybe we should state that these settings only apply to tcproute, tlsroute resources, so that users don't expect this timeout to apply also in case of HTTP (over TCP) connections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the state will be necessary to clear confusion. TCPClientTimeout can only be applied on listener whose protocol is TCP or TLS, it'll be used to set Envoy TCP Proxy's idle timeout eventually.

aoledk added 3 commits May 9, 2024 11:27
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (c4b0216) to head (bcbded8).
Report is 1 commits behind head on main.

❗ Current head bcbded8 differs from pull request most recent head b8ee9ca. Consider uploading reports for the commit b8ee9ca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
+ Coverage   66.97%   67.12%   +0.15%     
==========================================
  Files         164      164              
  Lines       23882    23773     -109     
==========================================
- Hits        15994    15958      -36     
+ Misses       6964     6896      -68     
+ Partials      924      919       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc guydc requested a review from a team May 13, 2024 11:39
@aoledk
Copy link
Contributor Author

aoledk commented May 15, 2024

/retest

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aoledk aoledk requested a review from guydc May 15, 2024 15:03
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 6912dc0 into envoyproxy:main May 15, 2024
23 checks passed
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request May 16, 2024
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request May 16, 2024
…tener (envoyproxy#3345)"

This reverts commit 6912dc0.

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@aoledk aoledk deleted the tcp-idle-timeout-api branch May 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support to configuring downstream idle timeout for TCP listener
4 participants