Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move delta to new linearization API #447

Merged
merged 3 commits into from
Jul 6, 2021
Merged

move delta to new linearization API #447

merged 3 commits into from
Jul 6, 2021

Conversation

alecholmez
Copy link
Contributor

@alecholmez alecholmez commented Jun 11, 2021 •
edited
Loading

Signed-off-by: Alec Holmes alecholmez@me.com

@alecholmez
move delta to new linearization API standard, close watch when OK
8462a1f 
Signed-off-by: Alec Holmes <alecholmez@me.com>
@alecholmez alecholmez changed the title move delta to new linearization API standard, close watch when OK move delta to new linearization API Jun 11, 2021
@alecholmez alecholmez requested a review from snowp June 21, 2021 16:02
snowp
snowp previously approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

snowp
snowp reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually had a few comments :) Looks good just some questions

pkg/cache/v3/cache.go Show resolved Hide resolved
pkg/server/delta/v3/server.go Outdated Show resolved Hide resolved
@alecholmez
remove out of scope code and fix comments
47c1e48 
Signed-off-by: Alec Holmes <alecholmez@me.com>
@alecholmez
Copy link
Contributor Author

Should be good now @snowp

@alecholmez alecholmez requested a review from snowp June 21, 2021 21:21
snowp
snowp reviewed Jun 22, 2021
View reviewed changes
pkg/cache/v3/cache.go Outdated Show resolved Hide resolved
@snowp snowp added the waiting label Jun 22, 2021
@alecholmez
remove value in comment
7514008 
Signed-off-by: Alec Holmes <alecholmez@me.com>
@alecholmez alecholmez requested a review from snowp June 23, 2021 16:28
@alecholmez
Copy link
Contributor Author

@snowp is this good to merge?

snowp
snowp approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alecholmez alecholmez merged commit b1a2dd5 into main Jul 6, 2021
@alecholmez alecholmez deleted the fix-watch branch July 6, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowp snowp snowp approved these changes

Assignees

@snowp snowp

Labels
waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alecholmez @snowp