Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#583][Sotw] Ensure resources are properly sent again if envoy unsubscribes then subscribes again to a resource #585

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[#583][Sotw] Ensure resources are properly sent again if envoy unsubscribes then subscribes again to a resource #585

wants to merge 6 commits into from

Commits on Aug 25, 2022

  1. Rework Cache interface to isolate it from streamState and make it mor… 

    …e uniform between sotw and delta

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
    @valerian-roche
    valerian-roche committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    a36df79 View commit details
    Browse the repository at this point in the history

  2. Fix unittest update wrongly inverted an assert 

    Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
    @valerian-roche
    valerian-roche committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    af7a06d View commit details
    Browse the repository at this point in the history

  3. [envoyproxy#583][Sotw] Ensure resources are properly sent again if en… 

    …voy unsubscribes then subscribes again to a resource

Fix potential deadlock in sotw-ads related to improper cleanup of watches in Linear cache when using delta in non-wildcard
Fix improper request set on sotw responses in Linear cache
Replaced lastResponse in sotw server by staged resources pending ACK

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
    @valerian-roche
    valerian-roche committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    4e00420 View commit details
    Browse the repository at this point in the history

  4. Synchronize test helper to pass race detection 

    Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
    @valerian-roche
    valerian-roche committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    42d626f View commit details
    Browse the repository at this point in the history

  5. Fix linting errors 

    Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
    @valerian-roche
    valerian-roche committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    fe06bc1 View commit details
    Browse the repository at this point in the history

  6. Ensure we don't create a race between cache and server in sotw. Move … 

    …nonce and version within streamState to properly track it with the pending resources

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
    @valerian-roche
    valerian-roche committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    408400c View commit details
    Browse the repository at this point in the history