rm printing resources in cache logs #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: envoyproxy#599 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
|
we also have a similar log line here that would be good to update: https://github.com/envoyproxy/go-control-plane/blob/b9e8d765366d34116028760e6192d40d69628636/pkg/cache/v3/linear.go |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
requested review from
sunjayBhatia and
alecholmez
and removed request for
sunjayBhatia and
alecholmez
sunjayBhatia
previously approved these changes
Oct 26, 2022
There was a problem hiding this comment.
looks good, made some tiny nits if you wanted to address them
cc @alecholmez if you had any other notes
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
requested review from
sunjayBhatia and
alecholmez
and removed request for
sunjayBhatia and
alecholmez
|
@sunjayBhatia thanks for review, addressed the comments, can you ptal |
sunjayBhatia
approved these changes
Oct 26, 2022
Nope looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #599
Signed-off-by: Arko Dasgupta arko@tetrate.io