Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the max value of 'max_request_bytes' is not match #225

Open
zbye opened this issue Apr 27, 2022 · 1 comment
Open

the max value of 'max_request_bytes' is not match #225

zbye opened this issue Apr 27, 2022 · 1 comment

Comments

@zbye
Copy link

zbye commented Apr 27, 2022

We have a problem when load the file envoy.yaml to xds developing based on this project. The max value in envoy.yaml is 4294967295, but the max value in this project is 2147483647 (Java's Int type).

The content in envoy.yaml as follows:

          http_filters:
          - name: envoy.ext_authz
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthz
              http_service:
                server_uri:
                  uri: 10.160.78.3:1001
                  cluster: ext-authz
                  timeout: 1s
              failure_mode_allow: false
              with_request_body:
                max_request_bytes: **4294967295**
                allow_partial_message: true

but when load the content to xds, the value exceeds the max value of Java's Int type.

[api/src/main/proto/envoy/config/filter/http/ext_authz/v2/ext_authz.proto]
uint32 max_request_bytes ;

uint32 corresponds to int in Java and int32 in Go, so this will result in an error when load the envoy.yaml.

I

@liangyuanpeng
Copy link

4294967295, but the max value in this project is 2147483647 (Java's Int type).

Yes, you are right.

I think this is not the side of envoy/envoy control problem, the really peoblem is really need to set the max value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants