Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all our CI jobs to AZP. #827

Merged
merged 12 commits into from
Apr 14, 2022
Merged

Adding all our CI jobs to AZP. #827

merged 12 commits into from
Apr 14, 2022

Conversation

mum4k
Copy link
Collaborator

@mum4k mum4k commented Apr 12, 2022

  • Decreasing integration test coverage threshold from 75% to 74.2%. The integration test coverage wasn't executing on CircleCI due to memory limitations. Our coverage dropped despite my attempts to execute this locally before each submission. While I did verify that the tests passed locally, I did not notice that the script is unable to verify the coverage when compiling on RBE. Also removing a TODO linked to Revert Integration Test Coverage percentage. Temporarily Lowered it to get a PR in separately from coverage in follow up PR. #564 which doesn't appear to be relevant anymore.
  • Modified ci/do_ci.sh so that clang_tidy uses all available CPUs when executing on AZP. Included a logging statement that prints this out in the output for debugging.
  • Setting a larger bazel timeout for the python_test that runs all our integration tests to avoid hitting the timeout on test execution.

Works on #820.

Signed-off-by: Jakub Sobon mumak@google.com

mum4k added 12 commits April 13, 2022 12:26
Signed-off-by: Jakub Sobon <mumak@google.com>
And removing unnecessary statements.

Signed-off-by: Jakub Sobon <mumak@google.com>
And fixing incorrect argument when running format.

Signed-off-by: Jakub Sobon <mumak@google.com>
It is sufficiently large.
Also reordering to match the execution order.

Signed-off-by: Jakub Sobon <mumak@google.com>
Also print out the actual number of CPUs used.

Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Enables the coverage test to pass again.

Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
This reverts commit 1955124.

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Copy link
Collaborator Author

mum4k commented Apr 13, 2022

@tomjzzhang please review and assign back to me once done.

@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Apr 13, 2022
@mum4k mum4k marked this pull request as ready for review April 13, 2022 17:13
Copy link
Contributor

@tomjzzhang tomjzzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mum4k mum4k merged commit 684a8af into envoyproxy:main Apr 14, 2022
@mum4k mum4k deleted the azure_all_jobs branch April 14, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants