Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: Make env vars configurable with defaults #51

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Nov 25, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Signed-off-by: Ryan Northey <ryan@synca.io>
@codecov-io
Copy link

Codecov Report

Merging #51 (75ebc98) into main (dc52dfd) will decrease coverage by 0.50%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   25.83%   25.33%   -0.51%     
==========================================
  Files          39       39              
  Lines         871      904      +33     
==========================================
+ Hits          225      229       +4     
- Misses        646      675      +29     
Impacted Files Coverage Δ
ui/src/service/modals.js 10.93% <0.00%> (ø)
ui/src/service/forms.js 12.98% <12.12%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc52dfd...75ebc98. Read the comment docs.

@phlax
Copy link
Member Author

phlax commented Nov 25, 2020

again a bit messy but basically works

@phlax phlax merged commit e03e4c6 into envoyproxy:main Nov 25, 2020
@phlax phlax deleted the services-env-vars branch December 2, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants