Make iteration order for Go maps consistent #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the keys before iteration to make the iteration order deterministic. This fixes a test flake where the first error returned by ValidateAll() didn't match the error returned by Validate(). Since the iteration order was unspecified, ValidateAll() would sometimes return the same set of errors in different orders. Signed-off-by: Alex Konradi <akonradi@google.com>
rodaine
approved these changes
Sep 10, 2021
|
Java and Python test failures will be addressed by #517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the keys before iteration to make the iteration order
deterministic. This fixes a test flake where the first error returned by
ValidateAll() didn't match the error returned by Validate(). Since the
iteration order was unspecified, ValidateAll() would sometimes return
the same set of errors in different orders.
Signed-off-by: Alex Konradi akonradi@google.com