Various small fixes #573
Merged
Various small fixes #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fix regression from #529. The code needs to handle enums at file scope and in a message. At the same time also handle arbitrary nesting. 2) Fix regression from #537 when dealing with single element string oneofs (and possibly other types being returned as pointer types vs. value types and breaking in queries. This fixes that for both C++ and Go. It's possible this fix shoudl be in PG* but doing it here for simplicity. 3) Modify the C++ validator registry to have polymorphic lookup capability which I want to use in Envoy. Signed-off-by: Matt Klein <mklein@lyft.com>
added 2 commits
February 26, 2022 16:52
|
@rodaine I think this should be ready, thanks. |
|
Hey @mattklein123, thanks for the fix on the enum import, and sorry for the regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix enum import in repeated field #529. The
code needs to handle enums at file scope and in a message. At the
same time also handle arbitrary nesting.
when dealing with single element string oneofs (and possibly other
types being returned as pointer types vs. value types and breaking in
queries. This fixes that for both C++ and Go. It's possible this fix
shoudl be in PG* but doing it here for simplicity.
capability which I want to use in Envoy.
Signed-off-by: Matt Klein mklein@lyft.com