New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade build dependencies #629
Conversation
elliotmjackson
commented
Sep 8, 2022
•
edited
edited
- Support arm64 and amd64 in Dockerfile
- Upgrade Go dependencies
- update Bazel dependencies from Go mod
960dedd
to
b1e2c31
Compare
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by the :validate_go
change. Can you explain what's happening to me?
@@ -55,7 +55,7 @@ java_proto_library( | |||
|
|||
alias( | |||
name = "go_default_library", | |||
actual = ":validate_go", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. If we've removed this, why are we changing to //validate:validate_go
elsewhere in this diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding offline comments here....
The only thing i did is get the dockerfile to run on arm machines and update the go version, consequently the go mod and bazel/repositories.bzl
with later versions…once i did this, i synced up the bazel repos from the go mod with
bazel run //:gazelle -- update-repos -from_file=go.mod -prune -to_macro=dependencies.bzl%go_third_party
thats when it went as made the huge diff 😛 I dont have a bazel-vocab so please excuse me. You can see everything bazel/gazelle did in commit ea5d03e… Updating bazel rules in bazel/repositories.bzl
was all me - needed to happen to enable an arm build. Trying to simulate amd was impossible, my machine quickly ran out of memory.
Signed-off-by: Elliot Jackson <elliot@buf.build>
4a955bb
to
dd47611
Compare
Signed-off-by: Elliot Jackson <elliot@buf.build>
Signed-off-by: Elliot Jackson <elliot@buf.build>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! After landing this, can you upgrade envoyproxy/envoy and make sure everything works?