Publish to Maven Central manually #644
Conversation
elliotmjackson
force-pushed
the
ejackson/remove-mvn
branch
2 times, most recently
from
613304e
to
b3d7dfc
Compare
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
elliotmjackson
force-pushed
the
ejackson/remove-mvn
branch
from
b3d7dfc
to
c51ac97
Compare
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
| READWRITE_API_KEY: ${{ secrets.SONATYPE_PASSWORD }} | ||
| ENVOY_PROXY_PROFILE_ID: ${{ secrets.ENVOY_PROXY_PROFILE_ID }} | ||
| run: | | ||
| python sonatype_nexus_upload.py \ |
There was a problem hiding this comment.
This publishes then in the right artifact directory?
Like does pgv-java-grpc-0.6.9-SNAPSHOT go to the directory ~/.m2/repository/io/envoyproxy/protoc-gen-validate/pgv-java-grpc/0.6.8-SNAPSHOT/pgv-java-grpc-0.6.8-SNAPSHOT.jar when you use the --local flag for the script?
There was a problem hiding this comment.
these were retrieved by running this on the runner.
find . -type f \( -iname "pom.xml" -o -iname "*.jar" \) -exec printf "%s\n" {}" \ " \;
you can see the successful run here
There was a problem hiding this comment.
I originally wanted to fetch these dynamically but the github actions syntax wasnt playing nice so I've abandoned that idea for now
| @@ -3,7 +3,7 @@ | |||
| <parent> | |||
| <artifactId>pgv-java</artifactId> | |||
| <groupId>io.envoyproxy.protoc-gen-validate</groupId> | |||
| <version>0.6.8-SNAPSHOT</version> | |||
| <version>0.6.9-rc.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Seems like a pain to manually do. What if we overwrite this via the python script since it's just a quick file io in CI?
There was a problem hiding this comment.
absolutely, i want to do this as part of a semver step I'll work on next.
In #640 we decided to publish to Apache Maven Central via
mvn publish:preparewhilst this provides simplicity, it removes some flexibility which we now understand is quite nice to have.This PR attempts to perform the action of
mvnon git tag creation manually by:mvn installWhilst the majority of these changes are for actions which run on tag creation, you can view a successful trial run here
To prepare for our next release I have also bumped the version in all poms to
0.6.9NOTE: this does not yet perform the release to public, some confidence gathering required to get us there.
Signed-off-by: Elliot Jackson 13633636+ElliotMJackson@users.noreply.github.com