xds client implementation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 1, 2020 09:50
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
added 2 commits
April 9, 2020 11:23
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
jyotimahapatra
changed the title
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
jyotimahapatra
commented
Apr 9, 2020
lita
reviewed
Apr 9, 2020
lita
reviewed
Apr 9, 2020
lita
reviewed
Apr 9, 2020
jessicayuen
reviewed
Apr 9, 2020
added 5 commits
April 9, 2020 17:26
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
added 3 commits
April 15, 2020 09:30
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
lita
reviewed
Apr 17, 2020
lita
reviewed
Apr 17, 2020
lita
reviewed
Apr 17, 2020
lita
reviewed
Apr 17, 2020
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
lita
reviewed
Apr 17, 2020
Closed
added 3 commits
April 17, 2020 11:45
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
added 4 commits
April 17, 2020 12:03
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
lita
reviewed
Apr 17, 2020
|
Last set of comments, otherwise looks LGTM. will approve once that select statement is cleaned up. |
added 2 commits
April 17, 2020 14:46
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
lita
reviewed
Apr 17, 2020
| defer cancelFunc() | ||
| select { | ||
| case <-ctx.Done(): | ||
| // Context was cancelled, hence this is not an erroneous scenario. |
There was a problem hiding this comment.
Shouldn't this be above the case? 🤔 Not sure about go formatting so I could be wrong!
There was a problem hiding this comment.
hm...i will look at why lint is not catching it in the next PR.
lita
approved these changes
Apr 17, 2020
jessicayuen
pushed a commit
to jessicayuen/xds-relay
that referenced
this pull request
Apr 21, 2020
* Don't extend TTL for AddWatch (envoyproxy#60) Fixes envoyproxy#58 The expiration time should only be delayed in SetResponse, since the intent of the TTL was to avoid stale responses in the cache. Adding/removing watches should not affect the expiration time of a key. This change removes that extension from AddWatch, and envoyproxy#59 already omits the expiry time extension. Signed-off-by: Lisa Lu <lisalu@lyft.com> * xds client implementation (envoyproxy#46) Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com> * add With Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com> Co-authored-by: Lisa Lu <lisalu@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jyoti Mahapatra jmahapatra@lyft.com