Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvbios: Document INIT_RESET_BEGUN and INIT_RESET_END #189

Merged

Conversation

Echelon9
Copy link
Member

@Echelon9 Echelon9 commented Jun 2, 2019

This series adds support to nouveau for two opcodes seen on VBIOSes prior to the locked-down PMU taking over responsibility for executing devinit scripts.

Signal that the reset sequence has begun.

This opcode signals that the software reset sequence has begun.
Ordinarily, no actual operations are performed by the opcode.
However it allows for possible software work arounds by devinit
engines in software agents other than the VBIOS, such as the resman,
FCODE, and EFI driver. This opcode is designed to be included in
the devinit script immediately after the NV_PMC_ENABLE register
has be written to put most engines into a reset state.

Present on [core6,)

Source:
- https://download.nvidia.com/open-gpu-doc/Devinit/1/devinit.xml#INIT_RESET_BEGUN
Signal that the reset sequence has completed.

This opcode signals that the software reset sequence has completed.
Ordinarily, no actual operations are performed by the opcode.
However it allows for possible software work arounds by devinit
engines in software agents other than the VBIOS, such as the resman,
FCODE, and EFI driver. This opcode is designed to be included in
the devinit script immediately after the NV_PMC_ENABLE register
has be written to take most of the engines out of the reset state.

Present on [core6,)

Source:
- https://download.nvidia.com/open-gpu-doc/Devinit/1/devinit.xml#INIT_RESET_END
@Echelon9 Echelon9 requested review from karolherbst, imirkin, a user and Lyude June 2, 2019 14:12
Copy link
Contributor

@Lyude Lyude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nitpicks

nvbios/nvbios.c Show resolved Hide resolved
nvbios/nvbios.c Show resolved Hide resolved
@Echelon9
Copy link
Member Author

Echelon9 commented Jun 5, 2019

Reviewed on IRC by @Lyude

@Echelon9 Echelon9 merged commit 12f3c22 into envytools:master Jun 5, 2019
@Echelon9 Echelon9 deleted the fix/devinit-init_reset_begun-end branch June 5, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants