Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visited links from @Technical-13 's patch #113

Merged
merged 3 commits into from
Jan 7, 2014
Merged

Conversation

stwalkerster
Copy link
Member

This is @Technical-13 's patch, reverted, reverted, reverted again, and finally reverted (I think...).

I've moved it out here again so it can have a bit more love and attention before being merged back in. Please let me do the merge, and don't just hit the merge button on github cos it'll probably mess up due to the amount of messing around I've done with this.

I'm hoping to extend bootstrap a bit and make the visited links use the browser history instead of javascript, and define a few new styles which are subtly different, but still clearly the button type they're meant to be.

@ghost ghost assigned stwalkerster Jan 7, 2014
@Manishearth
Copy link
Contributor

Those commit messages are scary.

@stwalkerster
Copy link
Member Author

yeah, I do apologise. 😢

@cyberpower678
Copy link

It could've been worse. :p stwalkerster could've reverted a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a revert of a merge of pull request #102

@stwalkerster
Copy link
Member Author

This probably depends on in 1a7b150 and hence #101

This bugs out on a right click ( @Technical-13 ), and also gets reset on
a reload, but I don't know if the latter is intended behaviour.

I tried using :visited CSS pseudo-classes, but that failed miserably.
stwalkerster added a commit that referenced this pull request Jan 7, 2014
@stwalkerster stwalkerster merged commit c9901fd into master Jan 7, 2014
@stwalkerster stwalkerster deleted the visited-links branch January 7, 2014 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants