Skip to content

Commit

Permalink
Update MHC annotation
Browse files Browse the repository at this point in the history
We have renamed the annotation to machine.openshift.io/remediation-strategy: external-baremetal to reflect the possibility there might be other external remediation strategies in future. The reboot based external remediation strategy is currently focused on bare metal use cases. See also openshift/machine-api-operator#476
  • Loading branch information
enxebre committed May 5, 2020
1 parent 0507a7d commit 7fa68f7
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions enhancements/machine-api/machine-health-checking.md
Expand Up @@ -51,7 +51,8 @@ Reduce administrative overhead to run a cluster and ability to respond to failur

- Providing administrator-defined short-circuiting of automated remediation when multiple nodes are unhealthy at the same time.

- Allowing a new and custom remediation developed outside the machine-healthcheck controller and enable its use via annotation, e.g baremetal reboot.
- Enable experimental remediation systems to be developed outside the machine-healthcheck controller via annotation, e.g baremetal reboot.
- If a strong need for multiple external remediation systems ever emerge a follow up proposal fleshing out stronger integration details must be provided for this to be supported as non-experimetal.


### Non-Goals
Expand Down Expand Up @@ -156,9 +157,9 @@ Out of band:

![Machine health check](./mhc.svg)

#### Out of tree remediation controller, e.g baremetal reboot:
- An external remediation can plug in by setting the `healthchecking.openshift.io/strategy: reboot` on the MHC resource.
- An external remediation controller remediation could then watch machines annotated with `healthchecking.openshift.io/remediation: reboot` and react as it sees fit.
#### Out of tree experimental remediation controller, e.g baremetal reboot:
- An external remediation can plug in by setting the `machine.openshift.io/remediation-strategy` on the MHC resource.
- An external remediation controller remediation could then watch machines annotated with `machine.openshift.io/remediation-strategy: external-baremetal` and react as it sees fit.

### Risks and Mitigations

Expand Down

0 comments on commit 7fa68f7

Please sign in to comment.