Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-2210:Create a new form control for embedding diagrams #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jona42-ui
Copy link

Here's a summary of the functionalities I have tackled for the afe-diagram-embed component:

Rendering the Diagram: I implemented the rendering logic to display the diagram within the component using an <img> tag or any appropriate method based on your requirements.

Annotation Button: I added an annotation button to the component, which, when clicked, opens an external application (e.g., React Image Annotate) for annotating the diagram. i used window.open to launch the external application.

Custom Styling: I customized the component's styles in the associated SCSS file (afe-diagram-embed.component.scss) to achieve the desired visual appearance. i ensured the component followed the required theming and styling guidelines, such as toggling the theme based on the "dark" input, though more designs will follow

Custom Control Integration: i assumed that the afe-diagram-embed component is a custom control within the form engine. However, we haven't integrated it fully with the form submission process yet. We focused on the rendering and annotation functionalities for now.

Issue: https://issues.openmrs.org/browse/O3-2210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant