Fixes ENYO-816 #112
Merged
Fixes ENYO-816 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without cachePoint: true, FlyweightRepeater can't decorate events with the row index as designed Issue: ENYO-816 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
aarontam
added a commit
that referenced
this pull request
Jan 27, 2015
Fixes ENYO-816 Reviewed-By: Krishna Rangarajan (krishna.rangarajan@lge.com) Integrated-By: Aaron Tam (aaron.tam@lge.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The event needs to pass through FlyweightRepeater because it decorates the event with the index but, since it doesn't have a handler for the event it isn't registered as a target. So, it works the first time because the bubble cache hasn't been initialized but once it has, it gets skipped.
Fix
Add cachePoint: true to FlyweightRepeater
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)