Fixes ENYO-2223 #2375
Merged
Fixes ENYO-2223 #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overflow: hidden introduces a new scrolling context such that focus()-ing a control will set the scrollTop/scrollLeft of the scroll context node so the focused control can be in view. We want to limit the number of scrolling contexts so we can prevent this scrolling effectively without unnecessary onscroll handlers. Issue: ENYO-2223 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)
always present. Enyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)
aarontam
added a commit
that referenced
this pull request
Aug 4, 2015
Fixes ENYO-2223 Reviewed-by: Roy Sutton (roy.sutton@lge.com) Integrated-By: Aaron Tam (aaron.tam@lge.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Programmatic
focus()-ing controls causes the browser to scroll the control into view usingscrollTopandscrollLefton the nearest scrolling context ancestor that would bring it into viewFix
Remove
overflowfrom intermediate controls within scroller so that scrolling can be suppressed on the scroller.Enyo-DCO-1.1-Signed-off-by: Ryan Duffy (ryan.duffy@lge.com)