Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support power_supply and socket icons #155

Open
Cguy7777 opened this issue Jul 2, 2023 · 5 comments
Open

Support power_supply and socket icons #155

Cguy7777 opened this issue Jul 2, 2023 · 5 comments
Assignees
Labels
generator Map generation issues icon Icon requests and other icon related issues
Projects

Comments

@Cguy7777
Copy link

Cguy7777 commented Jul 2, 2023

Rendering icons for various sockets (socket:<type>) would be wonderful. The main use would be identifying supported chargers at EV charging stations, but this would also be useful for indicating outlets at campsites, public phone chargers, or anywhere else with available power. Care should be taken so that socket:whatever=0 does not create misleading icons.

As an extra bonus, rendering the socket's power output (socket:whatever:output) adjacent to it would be very helpful for those looking for a place to plug in: if your car supports it, a 350 kW charger will get you back on the road a lot faster than an 50 kW charger.

power_supply is a generic tag to simply indicate if a feature has power available, often on camping sites; in the past this was used to indicate specific sockets, but this is deprecated. A lightning bolt icon (for yes), or lightning bolt with an X (for no) could show this.

@enzet enzet self-assigned this Aug 12, 2023
@enzet enzet added icon Icon requests and other icon related issues generator Map generation issues labels Aug 12, 2023
@enzet
Copy link
Owner

enzet commented Aug 12, 2023

@Cguy7777 Thank you the good issue!

I'm in the middle of transferring icons to a separate project Röntgen, so please check all the icon changes there.

According to Taginfo, the most popular values (with more than 1000 usages) of socket:* are

Tag Usages
socket:type2 42930
socket:typee 12818
socket:chademo 11004
socket:schuko 6191
socket:type1 3147
socket:tesla_supercharger 1291

I'll try to support them first.

@enzet enzet added this to In progress in Support Aug 12, 2023
@enzet
Copy link
Owner

enzet commented Aug 13, 2023

@Cguy7777 I've started with the socket:type2. There is a connector_type_2 icon in the Röntgen project. Are you OK with this style?

connector_type_2

@enzet enzet moved this from In progress to Review from author needed in Support Aug 13, 2023
@Cguy7777
Copy link
Author

@enzet Yes, that looks quite nice. Thank you for working on this!

@enzet enzet moved this from Review from author needed to In progress in Support Aug 14, 2023
enzet added a commit to enzet/Roentgen that referenced this issue Aug 14, 2023
@enzet
Copy link
Owner

enzet commented Aug 14, 2023

I've added icons to Röntgen icon set. I'm not sure about Tesla icon. Is it OK to have one connector type for Tesla connectors?

connectors

@Cguy7777
Copy link
Author

These icons look great! One minor note with the Type 1 icon: it might be more quickly recognizable if the protrusion on the bottom of the connector is included (pictured below).
Type 1 connector

For the Tesla connectors, I recommend against using a single icon for all of them. I'm in the US, so I'm not as familiar with the situation elsewhere, but from what I can tell, it looks like this:

  • In North America, socket:tesla_supercharger, socket:tesla_destination, and socket:tesla_standard all use the NACS port. I recommended rendering the connector itself, rather than something with the Tesla logo, since Tesla has opened the standard and many automakers have agreed to use these ports in the future on North American models. Optionally, the icon could differentiate between supercharger (DC) and destination (AC) types.
  • In Europe, socket:tesla_supercharger is a Type 2 connector with repurposed pins to allow for DC charging. It is not compatible with standard Type 2 connectors. The icon you made would be good for that. socket:tesla_supercharger_ccs are Tesla-branded Type 2 Combo ports (usually tagged as socket:type2_combo), which can use the same icon as any other Type 2 Combo port. Tesla Destination chargers in Europe use a standard Type 2 port, so I think socket:tesla_destination can use the Type 2 icon there. I'm not sure what socket:tesla_standard represents in Europe.
  • There is also socket:tesla_roadster. This is a connector used only on the original Tesla Roadster. These are very rare, and should not share an icon with other Tesla connectors. A dedicated icon is low priority.

To summarize:

Socket North America Europe
tesla_supercharger Render as NACS Render as modified Type 2 (perhaps your icon)
tesla_supercharger_ccs ? Render as Type 2 Combo
tesla_destination Render as NACS Render as Type 2
tesla_standard Render as NACS ?
tesla_roadster Render as Tesla Roadster Render as Tesla Roadster

MapComplete has a table of sockets they support here.

In addition to Tesla connectors, the next two most important connectors to support would probably be Type 1 Combo (non-Tesla standard for DC charging in North America, although it looks like it will give way to NACS in the future) and Type 2 Combo (standard for DC charging in Europe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Map generation issues icon Icon requests and other icon related issues
Projects
Status: In Progress
Support
  
In progress
Development

No branches or pull requests

2 participants