Fix GalaxySimulation boundary to work correctly with DualEnergyFormalism #216
Conversation
| if( UseMetallicityField ) | ||
| BoundaryValue[MetalNum][dim][0][index] = 1.0e-10; | ||
| BoundaryValue[MetalNum][dim][0][index] = 0.1 * BoundaryValue[DensNum][dim][0][index] * CoolData.SolarMetalFractionByMass; // 0.1 solar metallicity |
There was a problem hiding this comment.
@gregbryan what is the justification for hardwiring this to 0.1 Solar? I'm happy to go along with it, I just don't understand!
There was a problem hiding this comment.
No good justification -- a parameter needs to be created here but I feel it is a bit beyond the scope of this PR (this line is just to make a slightly less egregious choice). I propose that we accept this PR as is and I create an issue for this problem (as described below).
New issue:
A parameter which controls the metallicity of the inflowing gas in this problem should be created and connected (requires changes to GalaxySimulationInitialize.C, Grid_GalaxySimulationInitialize.C, and ExternalBoundary_SetGalaxySimulationBoundary). In particular, a new global parameter in the GalaxySimulationRPSWind family would need to be created, set and used in those routines. Currently the metallicity inflow is hard-wired to 0.1 solar as the least bad thing.
There was a problem hiding this comment.
That sounds great to me. I'll approve and merge.
There was a problem hiding this comment.
@gregbryan I went ahead and made this as issue #236
This small PR makes a few corrections to the specialized ExternalBoundary machinery that is part of the GalaxySimulation framework so that the gas coming in the boundary correctly respects the DualEnergyFormalism, HydroMethod, and Multispecies flags.