Shorten testing #102
Merged
Shorten testing #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jobordner this seems pretty straightforward, but it seems that none of the CircleCI tests actually ran on this PR - do you have any idea why? As I look at the actual files, I don't see any reason why they wouldn't run... |
bwoshea
approved these changes
May 20, 2021
|
@jobordner awesome, thank you! |
gregbryan
approved these changes
May 20, 2021
jwise77
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI tests have been failing due to timing out on individual tests. While testing needs some more serious updating to bring everything back online again (unit tests, cosmology, etc.), this is intended as a quick fix to shorten the time of longer tests so that CircleCI doesn't time out. With the current tests being run, that's just "adapt-L5", which does simple hydro on a 2D AMR mesh, and "mesh-balanced", which is obsolete and redundant with adapt-L5 (it doesn't test load balancing as its current categorization would indicate; "balanced" here refers to maintaining the 2-1 mesh refinement jump limit). When cosmology tests get re-added back in they will need to be updated to shorten their times as well.