Fixing another bug related to builds without Grackle #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabruzzo
force-pushed
the
no-grackle_bugfix
branch
from
ad01cf4
to
aae4793
Compare
|
Looks good so far! I'll approve it when you finish with the testing and change it from WIP. |
This attempt tries to build on the existing CI commands
mabruzzo
force-pushed
the
no-grackle_bugfix
branch
from
41efba6
to
5ea73e4
Compare
…d a minor change that broke builds without Grackle
…e more descriptive
|
This is now ready for review. If there were ever a PR that should be squashed while merging, this would be the one. |
jwise77
approved these changes
Jun 1, 2021
mabruzzo
commented
Jun 1, 2021
|
@bwoshea approved in his comment but didn't hit the approve button. That's 2 approvals and I'm squashing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #49 introduced a minor change that breaks builds without Grackle (again).
I've fixed this locally (it's a really easy fix). But I'm taking this as an opportunity to try to setup a CircleCi test to verify that Enzo-E can be built without Grackle (Our other tests already take a while, so I'm not going to run any tests with this build; I'm just checking if the build succeeds).
I'm intentionally going to make some tests fail while testing this, but this will be ready for review by tomorrow. (I'll change this from WIP once it's ready and I'll add an edit to this post confirming that it's ready).
EDIT: I'm done. This is now ready for review.