Suppress warnings charm++ module headers #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us greatly reduce the number of manually listed items in target_include_directory. It's also an important step towards untangling the giant knot of dependencies (that's important for speeding up compilation)
…generates from .ci files
mabruzzo
force-pushed
the
suppress-warnings-charm++-module-headers
branch
from
cc5126a
to
f07c973
Compare
gregbryan
requested changes
Jul 2, 2023
|
This is one of the PRs where we decided that we only needed 1 approval and Greg signed off on it (even though he never explicitly hit approve), so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds directly on PR #272 (it shouldn't be merged until afterwards).
This PR takes steps to suppress compiler warnings in the header files generated by
charmcfrom.ci(these warnings are really just noise -- we can't do much about them without altering charm++).This is essentially done by telling the compiler to treat them like system headers with the (i.e. passing the
-isystemflag togccorclang-- this may not suppress warnings on all compilers, but it's a good start)In more detail, we now:
charmcfrom.cifiles into their own sub-directories -- a subdirectory is automatically made for headers generated from thecifiles from theCello-layer and another is created for the headers generated from thecifile from theEnzo-layer.