Value class tweaks
#300
Merged
Value class tweaks
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivating factor was to make it easier to work directly with instances of the ``Value`` class, rather than always working with pointers to it.
…code is that that the destructors always run.
…nt operation, and that the destructor isn't doing anything funky.
…p-allocations in certain cases (relevant for inflow-boundaries). Also added two new test-cases to test_Value.cpp that check previously untested code-paths (including the new micro-optimization).
…d ``Value`` classes
gregbryan
approved these changes
Jul 2, 2023
jobordner
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the
Valueclass (and consequently theScalarExprclass), so that it's easier to work with instances of the class more easily (rather than always working with pointers to instances). These changes mainly involve tweaks to the constructors/destructors.It also adds a minor optimization to
ScalarExpr(relevant for inflow boundaries).Finally, the
test_Valueunit tests were refactored and extended to explicitly test this new functionality.