Compile Time Improvement: Isolate boost::filesystem as a depenendency of cello.cpp #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of cello.cpp Out of curiosity, I was using clang's -ftime-trace flag to test profile where most of the compile time was being spent. Unsurprisingly, a lot of the time (maybe 30% - 50% per source file is spent reading in header files). A lot of this time is spent reading the ``<charm++>`` and C++ standard library headers. I hope to look at that in the future. Somewhat surprisingly, every source file was spending ~0.4 seconds just reading <boost/filesystem> (this may be a slight underestimate). Given that we have over 220 source files, that's about 80 seconds per build (in serial). For context, a serial build on my machine probably takes ~15 minutes (maybe more). This was not very rigorous, but it seemed like an easy win.
gregbryan
approved these changes
Jul 7, 2023
|
@mabruzzo Can you resolve the conflicts? Then we can merge since I've marked this as a 1 reviewer PR. |
|
This PR now passes all of the tests and is up-to-date with the tip of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of curiosity, I was using clang's -ftime-trace flag to test profile where most of the compile time was being spent. Unsurprisingly, a lot of the time (maybe 30% - 50% per source file is spent reading in header files). A lot of this time is spent reading the
<charm++>and C++ standard library headers. I hope to look at that in the future.Somewhat surprisingly, every source file was spending ~0.4 seconds just reading <boost/filesystem> (this may be a slight underestimate). Given that we have over 220 source files, that's about 80 seconds per build (in serial). For context, a serial build on my machine probably takes ~15 minutes (maybe more). This was not very rigorous, but it seemed like an easy win to slightly improve build times by a few percent.