Convert Enzo/hydro-mhd into a subcomponent (Build Restructuring Part 1)
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> We needed to introduce an include statement into EnzoInitialBCenter.cpp since we reuse some of the Bfield functionality from the hydro-layer to help initialize magnetic fields -> EnzoPermutedCoordinates got moved into the utils subdirectory because it can be used in more cases than just hydro. For example, it is used in the initializer for the Shock Tube test problem. But, I could easily be convinced to put it back.
… into subtargets.
mabruzzo
force-pushed
the
enzo-hydro-mhd-subcomponents
branch
from
4856f78
to
d2ec7f9
Compare
mabruzzo
changed the title
Enzo/hydro-mhd into a subcomponent (Build Restructuring Part 1)
bwoshea
approved these changes
Feb 20, 2024
|
@mabruzzo this is ready to merge once the branch is updated to include changes from main! |
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
Enzo/hydro-mhdinto "subcomponents" that are compiled separately from the rest of the enzo-layer. This should improve compilation-times and the time it takes to perform a rebuild after a small change to a header.This is part of a general restructuring that I'm applying to the whole enzo-layer. A separate PR has been proposed, #333, to update the website documentation to explain my thought-process.
However, it is worth separating this PR from #333. If we ultimately decide NOT to apply this restructuring strategy to the rest of Enzo-Layer (in which case #333 will be rejected), I think it makes a lot of sense for the
Enzo/hydro-mhdsubdirectory.I will also post a series of other PRs that apply similar changes to other parts of the Enzo-Layer. (Part of the reason that they have been separated is that they touch a bunch of header files)