Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param prototype - first batch of initializers #349

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Param prototype - first batch of initializers #349

merged 4 commits into from
Apr 3, 2024

Conversation

mabruzzo
Copy link
Contributor

Followup from #341: moved parameter parsing the first batch of problem-initializers from EnzoConfig into constructors.

This includes EnzoInitialInclinedWave and EnzoInitialShockTube.

This was referenced Mar 26, 2024
Merged
Merged
jwise77
jwise77 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jwise77 jwise77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first PR I'm reviewing with the ParameterGroup. It's a great addition and makes passing parameters much easier and cleaner. Thanks!

@clairekope clairekope self-requested a review April 2, 2024 19:10
@clairekope clairekope merged commit a5f7ecf into enzo-project:main Apr 3, 2024
7 checks passed
@mabruzzo mabruzzo mentioned this pull request May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwise77 jwise77 jwise77 approved these changes

@clairekope clairekope clairekope approved these changes

@bwoshea bwoshea Awaiting requested review from bwoshea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mabruzzo @jwise77 @clairekope