Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Handle non-trading days in dataset #57

Closed
ghost opened this issue Apr 17, 2020 · 0 comments · Fixed by #60
Closed

[FEATURE] Handle non-trading days in dataset #57

ghost opened this issue Apr 17, 2020 · 0 comments · Fixed by #60
Labels
bug Something isn't working r-dev R support

Comments

@ghost
Copy link

ghost commented Apr 17, 2020

Problem description

Current dataset includes weekends and non-trading days and tags them as rows all with N/A values. Data could be treated either by removing the non-trading days, or filling these days with the last value.

Environment

  • platform (e.g. Linux, OSX, Windows): platform-independent
  • lightkurve version (e.g. 1.0b6): n/a
  • installation method (e.g. pip, conda, source): all
@ghost ghost added bug Something isn't working r-dev R support labels Apr 17, 2020
@ghost ghost self-assigned this Apr 17, 2020
@ghost ghost mentioned this issue Apr 22, 2020
Closed
@ghost ghost linked a pull request Apr 25, 2020 that will close this issue
Handle non-trading days in dataset #57 #60
Merged
ghost pushed a commit that referenced this issue Apr 25, 2020
Merge pull request #60 from jgendrinal/r-dev
a116781 
Handle non-trading days in dataset #57
@ghost ghost closed this as completed Apr 25, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working r-dev R support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle non-trading days in dataset #57
0 participants