Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose types for better TypeScript usage #40

Merged
merged 7 commits into from
Dec 15, 2022
Merged

feat: expose types for better TypeScript usage #40

merged 7 commits into from
Dec 15, 2022

Conversation

challet
Copy link
Contributor

@challet challet commented Dec 14, 2022

Is your pull request closing an issue?

Closes #39

Please explain the main changes of your pull request

Export types

Checklist

  • Have you added any new returned codes to the README file ?

enzoferey
enzoferey reviewed Dec 15, 2022
View reviewed changes
Copy link
Owner

@enzoferey enzoferey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initiative @challet 🙏🏻

I think it is correct to solve this issue by updating the README + exporting some of the types.

I'm suggesting a few adjustments to your changes 👇🏻

README.md Outdated Show resolved Hide resolved
lib/index.ts Outdated Show resolved Hide resolved
challet and others added 2 commits December 15, 2022 17:45
@challet @enzoferey
Update README.md
40d5b20 
Co-authored-by: Enzo Ferey <hello@enzoferey.com>
@challet @enzoferey
Don't export internal usage types
d9de0f1 
Co-authored-by: Enzo Ferey <hello@enzoferey.com>
@challet
Copy link
Contributor Author

challet commented Dec 15, 2022

Thanks for the suggestions, they have been commited

enzoferey
enzoferey reviewed Dec 15, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
enzoferey
enzoferey reviewed Dec 15, 2022
View reviewed changes
README.md Show resolved Hide resolved
@enzoferey
Copy link
Owner

enzoferey commented Dec 15, 2022 •
edited
Loading

Thanks @challet ! 🙏🏻

Could you please checkout the branch locally and run the format package script to make CI pass ? Then we can merge 👍🏻

enzoferey
enzoferey approved these changes Dec 15, 2022
View reviewed changes
Copy link
Owner

@enzoferey enzoferey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @challet !

@enzoferey enzoferey changed the title Export types feat: expose types for better TypeScript usage Dec 15, 2022
@enzoferey enzoferey added the enhancement New feature or request label Dec 15, 2022
@enzoferey enzoferey merged commit c410c1e into enzoferey:main Dec 15, 2022
@challet
Copy link
Contributor Author

challet commented Dec 15, 2022

You're welcome @enzoferey, thanks to you as well !

@challet challet deleted the export-types branch December 15, 2022 23:05
@enzoferey
Copy link
Owner

Just released v0.2.3 that includes these changes https://www.npmjs.com/package/@enzoferey/ethers-error-parser/v/0.2.3 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enzoferey enzoferey enzoferey approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Missing EthersError type with Typescript
2 participants
@challet @enzoferey