Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Re-]write tests where applicable #64

Closed
6 tasks done
travs opened this issue Jul 10, 2017 · 1 comment
Closed
6 tasks done

[Re-]write tests where applicable #64

travs opened this issue Jul 10, 2017 · 1 comment
Assignees
@travs

Comments

@travs
Copy link
Contributor

travs commented Jul 10, 2017 •
edited by retotrinkler
Loading

@retotrinkler suggested a major re-write of the tests in this repo, adn I agree.
When we get a coverage tool working (#55) then we can know where should direct our efforts.

  • Add general tests for asset tokens (preminedAsset)
  • add tests for etherToken
  • add tests for pricefeed
  • tests for Version
  • tests for invest/redeem
  • test Vault
@travs travs self-assigned this Jul 10, 2017
@retotrinkler
Copy link
Contributor

couldnt agree more

This was referenced Jul 11, 2017
Merged
Closed
@travs travs changed the title Re-write tests where applicable [Re-]write tests where applicable Jul 20, 2017
@travs travs mentioned this issue Jul 21, 2017
Merged
SeanJCasey added a commit that referenced this issue Jan 19, 2021
@SeanJCasey
refactor: move all external contract interfaces to shared directory (#64
63b8251 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travs travs

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travs @retotrinkler